mirrors/tracy
1
0
Fork 0
mirror of https://github.com/wolfpld/tracy synced 2025-04-30 04:43:53 +00:00
Code Issues Releases Wiki Activity

Separate call stack traversal from flame graph building.

Browse Source
This commit is contained in:
Bartosz Taudul 2024-12-16 16:41:00 +01:00
parent 9d839c52d1
commit 99d39e6eee
No known key found for this signature in database
GPG Key ID: B7FE2008B7575DF3
1 changed files with 55 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

54
profiler/src/profiler/TracyView_FlameGraph.cpp
View File

@ -210,13 +210,23 @@ void View::BuildFlameGraph( const Worker& worker, std::vector<FlameGraphItem>& d
void View::BuildFlameGraph( const Worker& worker, std::vector<FlameGraphItem>& data, const Vector<SampleData>& samples ) void View::BuildFlameGraph( const Worker& worker, std::vector<FlameGraphItem>& data, const Vector<SampleData>& samples )
{ {
struct FrameCache
{
uint64_t symaddr;
StringIdx name;
};
std::vector<FrameCache> cache;
for( auto& v : samples ) for( auto& v : samples )
{ {
cache.clear();
const auto cs = v.callstack.Val(); const auto cs = v.callstack.Val();
const auto& callstack = worker.GetCallstack( cs ); const auto& callstack = worker.GetCallstack( cs );
auto vec = &data;
const auto csz = callstack.size(); const auto csz = callstack.size();
if( m_flameExternal )
{
for( size_t i=csz; i>0; i-- ) for( size_t i=csz; i>0; i-- )
{ {
auto frameData = worker.GetCallstackFrame( callstack[i-1] ); auto frameData = worker.GetCallstackFrame( callstack[i-1] );
@ -228,22 +238,44 @@ void View::BuildFlameGraph( const Worker& worker, std::vector<FlameGraphItem>& d
const auto symaddr = frame.symAddr; const auto symaddr = frame.symAddr;
if( symaddr != 0 ) if( symaddr != 0 )
{ {
bool active = true; cache.emplace_back( FrameCache { symaddr, frame.name } );
if( !m_flameExternal ) }
}
}
}
}
else
{
for( size_t i=csz; i>0; i-- )
{
auto frameData = worker.GetCallstackFrame( callstack[i-1] );
if( frameData )
{
for( uint8_t j=frameData->size; j>0; j-- )
{
const auto frame = frameData->data[j-1];
const auto symaddr = frame.symAddr;
if( symaddr != 0 )
{ {
auto filename = m_worker.GetString( frame.file ); auto filename = m_worker.GetString( frame.file );
auto image = frameData->imageName.Active() ? m_worker.GetString( frameData->imageName ) : nullptr; auto image = frameData->imageName.Active() ? m_worker.GetString( frameData->imageName ) : nullptr;
if( IsFrameExternal( filename, image ) ) if( !IsFrameExternal( filename, image ) )
{ {
active = false; cache.emplace_back( FrameCache { symaddr, frame.name } );
} }
} }
if( active ) }
}
}
}
auto vec = &data;
for( auto& v : cache )
{ {
auto it = std::find_if( vec->begin(), vec->end(), [symaddr]( const auto& v ) { return v.srcloc == symaddr; } ); auto it = std::find_if( vec->begin(), vec->end(), [symaddr = v.symaddr]( const auto& v ) { return v.srcloc == symaddr; } );
if( it == vec->end() ) if( it == vec->end() )
{ {
vec->emplace_back( FlameGraphItem { (int64_t)symaddr, 1, frame.name } ); vec->emplace_back( FlameGraphItem { (int64_t)v.symaddr, 1, v.name } );
vec = &vec->back().children; vec = &vec->back().children;
} }
else else
@ -254,10 +286,6 @@ void View::BuildFlameGraph( const Worker& worker, std::vector<FlameGraphItem>& d
} }
} }
} }
}
}
}
}
static void SortFlameGraph( std::vector<FlameGraphItem>& data ) static void SortFlameGraph( std::vector<FlameGraphItem>& data )
{ {