From e01fa1a5fd303a22a7b249eb229ce5faa16cdb5c Mon Sep 17 00:00:00 2001 From: gabime Date: Mon, 25 Nov 2024 09:44:13 +0200 Subject: [PATCH] compilation error gcc 8.5 with [-Werror=suggest-override] (#3158) --- include/spdlog/sinks/base_sink.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/spdlog/sinks/base_sink.h b/include/spdlog/sinks/base_sink.h index cda8e365..9dedbfc0 100644 --- a/include/spdlog/sinks/base_sink.h +++ b/include/spdlog/sinks/base_sink.h @@ -28,10 +28,10 @@ public: base_sink &operator=(const base_sink &) = delete; base_sink &operator=(base_sink &&) = delete; - void log(const details::log_msg &msg) final; - void flush() final; - void set_pattern(const std::string &pattern) final; - void set_formatter(std::unique_ptr sink_formatter) final; + void log(const details::log_msg &msg) final override; + void flush() final override; + void set_pattern(const std::string &pattern) final override; + void set_formatter(std::unique_ptr sink_formatter) final override; protected: // sink formatter