From 4b7815798107b4226b5e00b6f49e4be5848328e6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Martin=20Ho=C5=99e=C5=88ovsk=C3=BD?=
 <martin.horenovsky@gmail.com>
Date: Thu, 7 Apr 2022 12:45:05 +0200
Subject: [PATCH] Remove Config::openStream function

It has become completely vestigial, as it only ever passed-through
the argument down to a different function, and being private
member function, it didn't even introduce a useful compilation
firewall.
---
 src/catch2/catch_config.cpp | 8 ++------
 src/catch2/catch_config.hpp | 1 -
 2 files changed, 2 insertions(+), 7 deletions(-)

diff --git a/src/catch2/catch_config.cpp b/src/catch2/catch_config.cpp
index 33ef9bdd..ff6198d9 100644
--- a/src/catch2/catch_config.cpp
+++ b/src/catch2/catch_config.cpp
@@ -79,10 +79,10 @@ namespace Catch {
                 defaultOutputUsed = true;
 
                 m_reporterStreams.push_back(
-                    openStream( data.defaultOutputFilename ) );
+                    makeStream( data.defaultOutputFilename ) );
             } else {
                 m_reporterStreams.push_back(
-                    openStream( *reporterSpec.outputFile() ) );
+                    makeStream( *reporterSpec.outputFile() ) );
             }
         }
     }
@@ -139,8 +139,4 @@ namespace Catch {
     unsigned int Config::benchmarkResamples() const               { return m_data.benchmarkResamples; }
     std::chrono::milliseconds Config::benchmarkWarmupTime() const { return std::chrono::milliseconds(m_data.benchmarkWarmupTime); }
 
-    Detail::unique_ptr<IStream const> Config::openStream(std::string const& outputFileName) {
-        return Catch::makeStream(outputFileName);
-    }
-
 } // end namespace Catch
diff --git a/src/catch2/catch_config.hpp b/src/catch2/catch_config.hpp
index 6b4a9205..582eb3e6 100644
--- a/src/catch2/catch_config.hpp
+++ b/src/catch2/catch_config.hpp
@@ -116,7 +116,6 @@ namespace Catch {
         std::chrono::milliseconds benchmarkWarmupTime() const override;
 
     private:
-        Detail::unique_ptr<IStream const> openStream(std::string const& outputFileName);
         ConfigData m_data;
 
         std::vector<Detail::unique_ptr<IStream const>> m_reporterStreams;