From b16c8c8ce42ae4bce2e0b922cd8441f519553a6c Mon Sep 17 00:00:00 2001 From: DarkWingMcQuack <38857302+DarkWingMcQuack@users.noreply.github.com> Date: Mon, 21 Nov 2022 17:05:04 +0100 Subject: [PATCH] Update TypeTools.hpp (#803) * Update TypeTools.hpp fix #802 by using checking `std::ceil(val) == std::floor(val)` instead of `val == static_cast(val)` to avoid warnings- * style: pre-commit.ci fixes Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> --- include/CLI/TypeTools.hpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/CLI/TypeTools.hpp b/include/CLI/TypeTools.hpp index 2048a014..65105c88 100644 --- a/include/CLI/TypeTools.hpp +++ b/include/CLI/TypeTools.hpp @@ -7,6 +7,7 @@ #pragma once // [CLI11:public_includes:set] +#include #include #include #include @@ -1545,8 +1546,7 @@ inline std::string sum_string_vector(const std::vector &values) { } else { if(val <= static_cast((std::numeric_limits::min)()) || val >= static_cast((std::numeric_limits::max)()) || - // NOLINTNEXTLINE(clang-diagnostic-float-equal,bugprone-narrowing-conversions) - val == static_cast(val)) { + std::ceil(val) == std::floor(val)) { output = detail::value_string(static_cast(val)); } else { output = detail::value_string(val);