From 7ff65c16f272ea8f0d98bb6458740f626c8924cb Mon Sep 17 00:00:00 2001
From: Comix <self@comix.he.cn>
Date: Thu, 6 Mar 2025 12:07:50 +0800
Subject: [PATCH] fix: promoting uint8_t/int8_t to make it casting result
 printable (#1132)

The underlying type of uint8_t/int8_t is unsigned char and signed char,
but IOStreams was specified to treat them just like char.

so promoting the casting value to get the expected value.

Signed-off-by: ComixHe <ComixHe1895@outlook.com>
---
 include/CLI/Option.hpp      | 12 ------------
 include/CLI/StringTools.hpp |  3 ++-
 tests/HelpersTest.cpp       |  3 +++
 3 files changed, 5 insertions(+), 13 deletions(-)

diff --git a/include/CLI/Option.hpp b/include/CLI/Option.hpp
index 0db6b317..8f2d6b65 100644
--- a/include/CLI/Option.hpp
+++ b/include/CLI/Option.hpp
@@ -776,18 +776,6 @@ class Option : public OptionBase<Option> {
                 _validate_results(results_);
                 current_option_state_ = old_option_state;
             }
-        } catch(const ValidationError &err) {
-            // this should be done
-            results_ = std::move(old_results);
-            current_option_state_ = old_option_state;
-            // try an alternate way to convert
-            std::string alternate = detail::value_string(val);
-            if(!alternate.empty() && alternate != val_str) {
-                return default_val(alternate);
-            }
-
-            throw ValidationError(get_name(),
-                                  std::string("given default value does not pass validation :") + err.what());
         } catch(const ConversionError &err) {
             // this should be done
             results_ = std::move(old_results);
diff --git a/include/CLI/StringTools.hpp b/include/CLI/StringTools.hpp
index a3ec254a..e17e11a2 100644
--- a/include/CLI/StringTools.hpp
+++ b/include/CLI/StringTools.hpp
@@ -33,7 +33,8 @@ namespace enums {
 template <typename T, typename = typename std::enable_if<std::is_enum<T>::value>::type>
 std::ostream &operator<<(std::ostream &in, const T &item) {
     // make sure this is out of the detail namespace otherwise it won't be found when needed
-    return in << static_cast<typename std::underlying_type<T>::type>(item);
+    // https://isocpp.org/wiki/faq/input-output#print-char-or-ptr-as-number
+    return in << +static_cast<typename std::underlying_type<T>::type>(item);
 }
 
 }  // namespace enums
diff --git a/tests/HelpersTest.cpp b/tests/HelpersTest.cpp
index 6c4e9606..58ca468c 100644
--- a/tests/HelpersTest.cpp
+++ b/tests/HelpersTest.cpp
@@ -38,6 +38,9 @@ TEST_CASE("TypeTools: Streaming", "[helpers]") {
 
     CHECK(std::string("string") == CLI::detail::to_string("string"));
     CHECK(std::string("string") == CLI::detail::to_string(std::string("string")));
+
+    enum class t1 : std::uint8_t { enum1, enum2 };
+    CHECK(CLI::detail::to_string(t1::enum1) == "0");
 }
 
 TEST_CASE("TypeTools: tuple", "[helpers]") {