Travis improvements and updates (#28)

* Adding check for style

* Adding reformats

* Fix syntax error in travis

* Support clang-format 3.9

* Adding clang-tidy check

.ci/check_style.sh

@@ -0,0 +1,17 @@
+#!/usr/bin/env sh
+set -evx
+
+clang-format --version
+
+git ls-files -- '*.cpp' '*.hpp' | xargs clang-format -i -style=file
+
+git diff --exit-code --color
+
+mkdir build || true
+cd build
+CXX_FLAGS="-Werror -Wall -Wextra -pedantic -std=c++11" cmake .. -DCLANG_TIDY_FIX=ON
+cmake --build .
+
+git diff --exit-code --color
+
+set +evx

.ci/prepare_altern.sh

@@ -9,6 +9,8 @@ if [ "$CXX" = "g++" ] ; then
 else
     ln -s `which clang-$COMPILER` clang
     ln -s `which clang++-$COMPILER` clang++
+    ln -s `which clang-format-$COMPILER` clang-format
+    ln -s `which clang-tidy-$COMPILER` clang-tidy
 fi
 
 export PATH="${DEPS_DIR}/extrabin":$PATH

.ci/travis.sh

@@ -6,3 +6,5 @@ cd build
 cmake .. -DCLI_SINGLE_FILE_TESTS=ON -DCMAKE_BUILD_TYPE=Debug
 cmake --build . -- -j2
 ctest --output-on-failure
+
+set +evx

.travis.yml

@@ -13,9 +13,16 @@ matrix:
   - compiler: clang
     addons:
       apt:
-        sources:
+        packages:
-        - llvm-toolchain-precise-3.5
+        - clang-3.9
-        - ubuntu-toolchain-r-test
+        - clang-format-3.9
+        - clang-tidy-3.9
+    env:
+    - COMPILER=3.9
+    - CHECK_STYLE=yes
+  - compiler: clang
+    addons:
+      apt:
         packages:
         - clang-3.5
     env:
@@ -37,8 +44,6 @@ matrix:
   - compiler: gcc
     addons:
       apt:
-        sources:
-        - ubuntu-toolchain-r-test
         packages:
         - g++-4.7
     env:
@@ -48,19 +53,21 @@ matrix:
 install:
 - python -c 'import sys; print(sys.version_info[:])'
 - DEPS_DIR="${TRAVIS_BUILD_DIR}/deps"
-- if [ "$TRAVIS_OS_NAME" = "linux" ]; then cd $TRAVIS_BUILD_DIR && . .ci/prepare_altern.sh
+- if [ "$TRAVIS_OS_NAME" = "linux" ]; then cd $TRAVIS_BUILD_DIR && . .ci/prepare_altern.sh ; fi
-  ; fi
+- if [ "$TRAVIS_OS_NAME" = "linux" ] ; then cd $TRAVIS_BUILD_DIR && . .ci/build_cmake.sh ; fi
-- if [ "$TRAVIS_OS_NAME" = "linux" ] ; then cd $TRAVIS_BUILD_DIR && . .ci/build_cmake.sh
+- if [ "$TRAVIS_OS_NAME" = "linux" ] ; then cd $TRAVIS_BUILD_DIR && . .ci/build_doxygen.sh ; fi
-  ; fi
-- if [ "$TRAVIS_OS_NAME" = "linux" ] ; then cd $TRAVIS_BUILD_DIR && . .ci/build_doxygen.sh
-  ; fi
 - if [ -n "$COVERALLS" ] ; then cd $TRAVIS_BUILD_DIR && . .ci/build_lcov.sh ; fi
 - cd "${DEPS_DIR}"
-- if [ "$(python -c 'import sys; print(sys.version_info[0])')" = "2" ] ; then pip
+- if [ "$(python -c 'import sys; print(sys.version_info[0])')" = "2" ] ; then pip install --user pathlib ; fi
-  install --user pathlib; fi
 script:
 - cd "${TRAVIS_BUILD_DIR}"
-- .ci/travis.sh
+- |
+  if [ -n "$CHECK_STYLE" ]
+  then
+    .ci/check_style.sh
+  else
+    .ci/travis.sh
+  fi
 after_success:
 - if [ -n "$COVERALLS" ] ; then cd $TRAVIS_BUILD_DIR && .ci/run_codecov.sh ; fi
 - echo "${TRAVIS_BRANCH}"

examples/enum.cpp

@@ -1,12 +1,8 @@
 #include <CLI/CLI.hpp>
 
-enum Level : std::int32_t {
+enum Level : std::int32_t { High, Medium, Low };
-    High,
-    Medium,
-    Low
-};
 
-int main(int argc, char** argv) {
+int main(int argc, char **argv) {
     CLI::App app;
 
     Level level;
@@ -15,9 +11,8 @@ int main(int argc, char** argv) {
 
     try {
         app.parse(argc, argv);
-    } catch (CLI::Error const& e) {
+    } catch(CLI::Error const &e) {
         app.exit(e);
     }
     return 0;
 }
-

examples/prefix_command.cpp

@@ -6,8 +6,7 @@ int main(int argc, char **argv) {
     app.prefix_command();
 
     std::vector<int> vals;
-    app.add_option("--vals,-v", vals)
+    app.add_option("--vals,-v", vals)->expected(1);
-        ->expected(1);
 
     std::vector<std::string> more_comms;
     try {

include/CLI/App.hpp

@@ -226,8 +226,6 @@ class App {
             throw OptionAlreadyAdded(myopt.get_name());
     }
 
-    
-
     /// Add option for non-vectors (duplicate copy needed without defaulted to avoid `iostream << value`)
     template <typename T, enable_if_t<!is_vector<T>::value, detail::enabler> = detail::dummy>
     Option *add_option(std::string name,
@@ -912,19 +910,19 @@ class App {
                 char *buffer = nullptr;
                 std::string ename_string;
 
-                #ifdef _MSC_VER
+#ifdef _MSC_VER
                 // Windows version
                 size_t sz = 0;
                 if(_dupenv_s(&buffer, &sz, opt->envname_.c_str()) == 0 && buffer != nullptr) {
                     ename_string = std::string(buffer);
                     free(buffer);
                 }
-                #else
+#else
                 // This also works on Windows, but gives a warning
                 buffer = std::getenv(opt->envname_.c_str());
                 if(buffer != nullptr)
                     ename_string = std::string(buffer);
-                #endif
+#endif
 
                 if(!ename_string.empty()) {
                     opt->add_result(ename_string);
@@ -1068,10 +1066,8 @@ class App {
     size_t _count_remaining_required_positionals() const {
         size_t retval = 0;
         for(const Option_p &opt : options_)
-            if(opt->get_positional()
+            if(opt->get_positional() && opt->get_required() && opt->get_expected() > 0 &&
-               && opt->get_required()
+               static_cast<int>(opt->count()) < opt->get_expected())
-               && opt->get_expected() > 0
-               && static_cast<int>(opt->count()) < opt->get_expected())
                 retval = static_cast<size_t>(opt->get_expected()) - opt->count();
 
         return retval;
@@ -1106,7 +1102,6 @@ class App {
                 }
             }
         }
-        
     }
 
     /// Parse a subcommand, modify args and continue

include/CLI/Option.hpp

@@ -433,9 +433,8 @@ class Option {
     /// Set the default value string representation
     void set_default_val(std::string val) { defaultval_ = val; }
 
-
     /// Set the type name displayed on this option
-    void set_type_name(std::string val) {typeval_ = val;}
+    void set_type_name(std::string val) { typeval_ = val; }
 
     ///@}
 

include/CLI/TypeTools.hpp

@@ -75,9 +75,8 @@ constexpr const char *type_name() {
 // Lexical cast
 
 /// Integers / enums
-template <typename T, enable_if_t<std::is_integral<T>::value
+template <typename T,
-    || std::is_enum<T>::value
+          enable_if_t<std::is_integral<T>::value || std::is_enum<T>::value, detail::enabler> = detail::dummy>
-    , detail::enabler> = detail::dummy>
 bool lexical_cast(std::string input, T &output) {
     try {
         output = static_cast<T>(std::stoll(input));
@@ -103,11 +102,9 @@ bool lexical_cast(std::string input, T &output) {
 }
 
 /// String and similar
-template <
+template <typename T,
-    typename T,
+          enable_if_t<!std::is_floating_point<T>::value && !std::is_integral<T>::value && !std::is_enum<T>::value,
-    enable_if_t<!std::is_floating_point<T>::value
+                      detail::enabler> = detail::dummy>
-                && !std::is_integral<T>::value
-                && !std::is_enum<T>::value, detail::enabler> = detail::dummy>
 bool lexical_cast(std::string input, T &output) {
     output = input;
     return true;

tests/AppTest.cpp

@@ -204,11 +204,7 @@ TEST_F(TApp, DefaultOpts) {
 }
 
 TEST_F(TApp, EnumTest) {
-    enum Level : std::int32_t {
+    enum Level : std::int32_t { High, Medium, Low };
-        High,
-        Medium,
-        Low
-    };
     Level level = Level::Low;
     app.add_option("--level", level);
 
@@ -218,11 +214,7 @@ TEST_F(TApp, EnumTest) {
 }
 
 TEST_F(TApp, NewEnumTest) {
-    enum class Level2 : std::int32_t {
+    enum class Level2 : std::int32_t { High, Medium, Low };
-        High,
-        Medium,
-        Low
-    };
     Level2 level = Level2::Low;
     app.add_option("--level", level);
 
@@ -231,7 +223,6 @@ TEST_F(TApp, NewEnumTest) {
     EXPECT_EQ(level, Level2::Medium);
 }
 
-
 TEST_F(TApp, RequiredFlags) {
     app.add_flag("-a")->required();
     app.add_flag("-b")->mandatory(); // Alternate term
@@ -440,7 +431,6 @@ TEST_F(TApp, InSetWithDefault) {
     EXPECT_THROW(run(), CLI::ConversionError);
 }
 
-
 TEST_F(TApp, InCaselessSetWithDefault) {
 
     std::string choice = "one";
@@ -532,7 +522,6 @@ TEST_F(TApp, VectorFixedString) {
     EXPECT_EQ(answer, strvec);
 }
 
-
 TEST_F(TApp, VectorDefaultedFixedString) {
     std::vector<std::string> strvec{"one"};
     std::vector<std::string> answer{"mystring", "mystring2", "mystring3"};
@@ -895,7 +884,7 @@ TEST_F(TApp, CheckSubcomFail) {
 
 // Added to test defaults on dual method
 TEST_F(TApp, OptionWithDefaults) {
-    int someint=2;
+    int someint = 2;
     app.add_option("-a", someint, "", true);
 
     args = {"-a1", "-a2"};
@@ -905,8 +894,8 @@ TEST_F(TApp, OptionWithDefaults) {
 
 // Added to test defaults on dual method
 TEST_F(TApp, SetWithDefaults) {
-    int someint=2;
+    int someint = 2;
-    app.add_set("-a", someint, {1,2,3,4}, "", true);
+    app.add_set("-a", someint, {1, 2, 3, 4}, "", true);
 
     args = {"-a1", "-a2"};
 
@@ -915,8 +904,8 @@ TEST_F(TApp, SetWithDefaults) {
 
 // Added to test defaults on dual method
 TEST_F(TApp, SetWithDefaultsConversion) {
-    int someint=2;
+    int someint = 2;
-    app.add_set("-a", someint, {1,2,3,4}, "", true);
+    app.add_set("-a", someint, {1, 2, 3, 4}, "", true);
 
     args = {"-a", "hi"};
 
@@ -925,7 +914,7 @@ TEST_F(TApp, SetWithDefaultsConversion) {
 
 // Added to test defaults on dual method
 TEST_F(TApp, SetWithDefaultsIC) {
-    std::string someint="ho";
+    std::string someint = "ho";
     app.add_set_ignore_case("-a", someint, {"Hi", "Ho"}, "", true);
 
     args = {"-aHi", "-aHo"};

tests/SubcommandTest.cpp

@@ -316,7 +316,6 @@ TEST_F(TApp, PrefixProgram) {
     auto ret_args = run();
 
     EXPECT_EQ(ret_args, std::vector<std::string>({"--mine", "--simple", "other"}));
-    
 }
 
 struct SubcommandProgram : public TApp {