From 45520a0ec411d60d262f9fc6f62d91e4647f01eb Mon Sep 17 00:00:00 2001 From: Henry Fredrick Schreiner Date: Tue, 28 Nov 2017 16:09:15 -0500 Subject: [PATCH] Fix error with if(string) --- include/CLI/App.hpp | 2 +- tests/IniTest.cpp | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/include/CLI/App.hpp b/include/CLI/App.hpp index a3b62249..a98352c5 100644 --- a/include/CLI/App.hpp +++ b/include/CLI/App.hpp @@ -589,7 +589,7 @@ class App { remove_option(config_ptr_); // Only add config if option passed - if(name) { + if(!name.empty()) { config_name_ = default_filename; config_required_ = required; config_ptr_ = add_option(name, config_name_, help, !default_filename.empty()); diff --git a/tests/IniTest.cpp b/tests/IniTest.cpp index c94420a3..695b3c26 100644 --- a/tests/IniTest.cpp +++ b/tests/IniTest.cpp @@ -429,7 +429,8 @@ TEST_F(TApp, IniSubFailure) { EXPECT_THROW(run(), CLI::INIError); } -d TEST_F(TApp, IniNoSubFailure) { + +TEST_F(TApp, IniNoSubFailure) { TempFile tmpini{"TestIniTmp.ini"};