From 2bea3983c0f9d30ee5ceacced230d2105d716989 Mon Sep 17 00:00:00 2001
From: Kannan <s.kannan89@gmail.com>
Date: Sun, 27 Oct 2019 11:53:27 -0600
Subject: [PATCH] Return empty string in Option::get_name() for hidden options
 (#333)

* Return empty string in Option::get_name() for hidden options

Fixes https://github.com/CLIUtils/CLI11/issues/332

* Remove to_lower() call

* Formatting

* Fix THelp.Hidden
---
 include/CLI/Option.hpp | 2 ++
 tests/HelpTest.cpp     | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/include/CLI/Option.hpp b/include/CLI/Option.hpp
index 14329d7d..e2123abb 100644
--- a/include/CLI/Option.hpp
+++ b/include/CLI/Option.hpp
@@ -652,6 +652,8 @@ class Option : public OptionBase<Option> {
     std::string get_name(bool positional = false, //<[input] Show the positional name
                          bool all_options = false //<[input] Show every option
                          ) const {
+        if(get_group().empty())
+            return {}; // Hidden
 
         if(all_options) {
 
diff --git a/tests/HelpTest.cpp b/tests/HelpTest.cpp
index 229d441b..9be442ef 100644
--- a/tests/HelpTest.cpp
+++ b/tests/HelpTest.cpp
@@ -92,7 +92,7 @@ TEST(THelp, Hidden) {
     EXPECT_THAT(help, HasSubstr("My prog"));
     EXPECT_THAT(help, HasSubstr("-h,--help"));
     EXPECT_THAT(help, HasSubstr("Options:"));
-    EXPECT_THAT(help, HasSubstr("[something]"));
+    EXPECT_THAT(help, Not(HasSubstr("[something]")));
     EXPECT_THAT(help, Not(HasSubstr("something ")));
     EXPECT_THAT(help, Not(HasSubstr("another")));
 }