From 0ff1f27374649a1d896d6bbe2910226b6381ad9c Mon Sep 17 00:00:00 2001
From: Henry Fredrick Schreiner <henry.fredrick.schreiner@cern.ch>
Date: Wed, 31 May 2017 11:07:06 -0400
Subject: [PATCH] Fix catch by value

---
 .clang-tidy               | 2 +-
 include/CLI/TypeTools.hpp | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/.clang-tidy b/.clang-tidy
index c27ef5a2..af9bc2b9 100644
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -1,6 +1,6 @@
 #Checks: '*,-clang-analyzer-alpha.*'
 #Checks: '-*,google-readability-casting,llvm-namespace-comment,performance-unnecessary-value-param,llvm-include-order,misc-throw-by-value-catch-by-reference,readability-container-size-empty,google-runtime-references,modernize*'
-Checks: '-*,llvm-namespace-comment,llvm-include-order,readability-container-size-empty'
+Checks: '-*,llvm-namespace-comment,llvm-include-order,readability-container-size-empty,misc-throw-by-value-catch-by-reference'
 HeaderFilterRegex: '.*hpp'
 CheckOptions:
 - key:             readability-braces-around-statements.ShortStatementLines
diff --git a/include/CLI/TypeTools.hpp b/include/CLI/TypeTools.hpp
index 7fd11314..b9afe37a 100644
--- a/include/CLI/TypeTools.hpp
+++ b/include/CLI/TypeTools.hpp
@@ -104,9 +104,9 @@ namespace detail {
         try{
             output = (T) std::stoll(input);
             return true;
-        } catch (std::invalid_argument) {
+        } catch (const std::invalid_argument&) {
             return false;
-        } catch (std::out_of_range) {
+        } catch (const std::out_of_range&) {
             return false;
         }
     }
@@ -117,9 +117,9 @@ namespace detail {
         try{
             output = (T) std::stold(input);
             return true;
-        } catch (std::invalid_argument) {
+        } catch (const std::invalid_argument&) {
             return false;
-        } catch (std::out_of_range) {
+        } catch (const std::out_of_range&) {
             return false;
         }
     }