mirrors/CLI11
1
0
Fork 0
mirror of https://github.com/CLIUtils/CLI11.git synced 2025-04-29 12:13:52 +00:00
Code Issues Releases Wiki Activity

Adding test and keeping validator API similar

Browse Source
This commit is contained in:
Henry Fredrick Schreiner 2017-11-23 22:47:36 -05:00 committed by Henry Schreiner
parent 3006f82bf6
commit 038eafed29
3 changed files with 27 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
include/CLI/Option.hpp
View File

@ -220,8 +220,13 @@ class Option : public OptionBase<Option> {
}
/// Adds a validator
Option *check(std::function<bool(std::string &)> validator) {
Option *check(std::function<bool(const std::string &)> validator) {
validators_.emplace_back(validator);
return this;
}
/// Adds a validator-like function that can change result
Option *transform(std::function<bool(std::string &)> validator) {
validators_.push_back(validator);
return this;
}

2
include/CLI/Validators.hpp
View File

@ -19,7 +19,7 @@ namespace CLI {
/// @defgroup validator_group Validators
/// @brief Some validators that are provided
///
/// These are simple `bool(std::string)` validators that are useful.
/// These are simple `bool(std::string&)` validators that are useful.
/// @{
/// Check for an existing file

20
tests/AppTest.cpp
View File

@ -1171,3 +1171,23 @@ TEST_F(TApp, SetWithDefaultsIC) {
EXPECT_THROW(run(), CLI::ConversionError);
}
// Added to test defaults on dual method
TEST_F(TApp, OrderedModifingValidators) {
std::vector<std::string> val;
auto m = app.add_option("-m", val);
m->transform([](std::string &x) {
x += "1";
return true;
});
m->transform([](std::string &x) {
x += "2";
return true;
});
args = {"-mone", "-mtwo"};
run();
EXPECT_EQ(val, std::vector<std::string>({"one12", "two12"}));
}