boost_mirror/histogram
1
0
Fork 0
mirror of https://github.com/boostorg/histogram.git synced 2025-05-09 23:04:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

extended comment to explain the issue

Browse Source
This commit is contained in:
Hans Dembinski 2019-06-10 16:53:04 +02:00
parent 7e40aaf689
commit 3a510aba6d
1 changed files with 11 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
test/detail_operators_test.cpp
View File

@ -51,17 +51,19 @@ void test_nan(std::false_type) {}
template <class T, class U>
void test_nan(std::true_type) {
// the Standard says: any comparison with nan is always false, except != which is always
const U nan = std::numeric_limits<U>::quiet_NaN();
// some of these tests fail on MSVC 19.10 to 19.14
// BOOST_TEST_NOT(nan < nan);
// BOOST_TEST_NOT(nan > nan);
// BOOST_TEST_NOT(nan == nan);
// BOOST_TEST_NOT(nan <= nan);
// BOOST_TEST_NOT(nan >= nan);
// BOOST_TEST(nan != nan);
// IEEE 754: Any comparison with nan is false, except != which is true.
// But some of the following tests fail on MSVC:
// BOOST_TEST_NOT(nan < nan); // true, should be false
// BOOST_TEST_NOT(nan > nan);
// BOOST_TEST_NOT(nan == nan);
// BOOST_TEST_NOT(nan <= nan); // true, should be false
// BOOST_TEST_NOT(nan >= nan);
// BOOST_TEST(nan != nan);
// Probably related:
// https://developercommunity.visualstudio.com/content/problem/445462/nan-nan-is-constant-folded-to-true-but-should-prob.html
// The tests below don't fail probably because constant-folding doesn't happen.
BOOST_TEST_NOT(T(1.0) < T(nan));
BOOST_TEST_NOT(T(1.0) > T(nan));