// Boost.Geometry (aka GGL, Generic Geometry Library) // Unit Test // Copyright (c) 2014, Oracle and/or its affiliates. // Contributed and/or modified by Menelaos Karavelas, on behalf of Oracle // Licensed under the Boost Software License version 1.0. // http://www.boost.org/users/license.html #ifndef BOOST_TEST_MODULE #define BOOST_TEST_MODULE test_is_valid #endif #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include "from_wkt.hpp" #ifdef BOOST_GEOMETRY_TEST_DEBUG #include "pretty_print_geometry.hpp" #endif namespace bg = ::boost::geometry; typedef bg::model::point point_type; typedef bg::model::segment segment_type; typedef bg::model::box box_type; typedef bg::model::linestring linestring_type; typedef bg::model::multi_linestring multi_linestring_type; // multi-geometries typedef bg::model::multi_point multi_point_type; //---------------------------------------------------------------------------- // returns true if a geometry can be converted to closed template < typename Geometry, typename Tag = typename bg::tag::type, bg::closure_selector Closure = bg::closure::value > struct is_convertible_to_closed { static inline bool apply(Geometry const&) { return false; } }; template struct is_convertible_to_closed { static inline bool apply(Ring const& ring) { return boost::size(ring) > 0; } }; template struct is_convertible_to_closed { typedef typename bg::ring_type::type ring_type; template static inline bool apply_to_interior_rings(InteriorRings const& interior_rings) { return bg::detail::check_iterator_range < is_convertible_to_closed, true // allow empty iterator range >::apply(boost::begin(interior_rings), boost::end(interior_rings)); } static inline bool apply(Polygon const& polygon) { return boost::size(bg::exterior_ring(polygon)) > 0 && apply_to_interior_rings(bg::interior_rings(polygon)); } }; template struct is_convertible_to_closed { typedef typename boost::range_value::type polygon; static inline bool apply(MultiPolygon const& multi_polygon) { return bg::detail::check_iterator_range < is_convertible_to_closed, false // do not allow empty multi-polygon >::apply(boost::begin(multi_polygon), boost::end(multi_polygon)); } }; //---------------------------------------------------------------------------- // returns true if a geometry can be converted to cw template < typename Geometry, typename Tag = typename bg::tag::type, bg::order_selector Order = bg::point_order::value > struct is_convertible_to_cw { static inline bool apply(Geometry const&) { return bg::point_order::value == bg::counterclockwise; } }; //---------------------------------------------------------------------------- struct default_validity_tester { template static inline bool apply(Geometry const& geometry, bool expected_result) { bool valid = bg::is_valid(geometry); BOOST_CHECK_MESSAGE( valid == expected_result, "Expected: " << expected_result << " detected: " << valid << " wkt: " << bg::wkt(geometry) ); return valid; } }; template struct validity_tester_linear { template static inline bool apply(Geometry const& geometry, bool expected_result) { bool valid = bg::dispatch::is_valid < Geometry, typename bg::tag::type, AllowSpikes >::apply(geometry); BOOST_CHECK_MESSAGE( valid == expected_result, "Expected: " << expected_result << " detected: " << valid << " wkt: " << bg::wkt(geometry) ); return valid; } }; template struct validity_tester_areal { template static inline bool apply(Geometry const& geometry, bool expected_result) { bool const irrelevant = true; bool valid = bg::dispatch::is_valid < Geometry, typename bg::tag::type, irrelevant, AllowDuplicates >::apply(geometry); BOOST_CHECK_MESSAGE( valid == expected_result, "Expected: " << expected_result << " detected: " << valid << " wkt: " << bg::wkt(geometry) ); return valid; } }; //---------------------------------------------------------------------------- template < typename ValidityTester, typename Geometry, typename ClosedGeometry = Geometry, typename CWGeometry = Geometry, typename CWClosedGeometry = Geometry, typename Tag = typename bg::tag::type > struct test_valid { template static inline void base_test(G const& g, bool expected_result) { #ifdef BOOST_GEOMETRY_TEST_DEBUG std::cout << "=======" << std::endl; #endif bool valid = ValidityTester::apply(g, expected_result); boost::ignore_unused(valid); #ifdef BOOST_GEOMETRY_TEST_DEBUG std::cout << "Geometry: "; pretty_print_geometry::apply(std::cout, g); std::cout << std::endl; std::cout << "wkt: " << bg::wkt(g) << std::endl; std::cout << std::boolalpha; std::cout << "is valid? " << valid << std::endl; std::cout << "expected result: " << expected_result << std::endl; std::cout << "=======" << std::endl; std::cout << std::noboolalpha; #endif } static inline void apply(Geometry const& geometry, bool expected_result) { base_test(geometry, expected_result); if ( is_convertible_to_closed::apply(geometry) ) { #ifdef BOOST_GEOMETRY_TEST_DEBUG std::cout << "...checking closed geometry..." << std::endl; #endif ClosedGeometry closed_geometry; bg::convert(geometry, closed_geometry); base_test(closed_geometry, expected_result); } if ( is_convertible_to_cw::apply(geometry) ) { #ifdef BOOST_GEOMETRY_TEST_DEBUG std::cout << "...checking cw open geometry..." << std::endl; #endif CWGeometry cw_geometry; bg::convert(geometry, cw_geometry); base_test(cw_geometry, expected_result); if ( is_convertible_to_closed::apply(cw_geometry) ) { #ifdef BOOST_GEOMETRY_TEST_DEBUG std::cout << "...checking cw closed geometry..." << std::endl; #endif CWClosedGeometry cw_closed_geometry; bg::convert(cw_geometry, cw_closed_geometry); base_test(cw_closed_geometry, expected_result); } } #ifdef BOOST_GEOMETRY_TEST_DEBUG std::cout << std::endl << std::endl << std::endl; #endif } }; //---------------------------------------------------------------------------- template struct test_valid_variant { static inline void apply(VariantGeometry const& vg, bool expected_result) { test_valid < default_validity_tester, VariantGeometry >::base_test(vg, expected_result); } }; //---------------------------------------------------------------------------- BOOST_AUTO_TEST_CASE( test_is_valid_point ) { #ifdef BOOST_GEOMETRY_TEST_DEBUG std::cout << std::endl << std::endl; std::cout << "************************************" << std::endl; std::cout << " is_valid: POINT " << std::endl; std::cout << "************************************" << std::endl; #endif typedef point_type G; typedef default_validity_tester tester; typedef test_valid test; test::apply(from_wkt("POINT(0 0)"), true); } BOOST_AUTO_TEST_CASE( test_is_valid_multipoint ) { #ifdef BOOST_GEOMETRY_TEST_DEBUG std::cout << std::endl << std::endl; std::cout << "************************************" << std::endl; std::cout << " is_valid: MULTIPOINT " << std::endl; std::cout << "************************************" << std::endl; #endif typedef multi_point_type G; typedef default_validity_tester tester; typedef test_valid test; test::apply(from_wkt("MULTIPOINT()"), false); test::apply(from_wkt("MULTIPOINT(0 0,0 0)"), true); test::apply(from_wkt("MULTIPOINT(0 0,1 0,1 1,0 1)"), true); test::apply(from_wkt("MULTIPOINT(0 0,1 0,1 1,1 0,0 1)"), true); } BOOST_AUTO_TEST_CASE( test_is_valid_segment ) { #ifdef BOOST_GEOMETRY_TEST_DEBUG std::cout << std::endl << std::endl; std::cout << "************************************" << std::endl; std::cout << " is_valid: SEGMENT " << std::endl; std::cout << "************************************" << std::endl; #endif typedef segment_type G; typedef default_validity_tester tester; typedef test_valid test; test::apply(from_wkt("SEGMENT(0 0,0 0)"), false); test::apply(from_wkt("SEGMENT(0 0,1 0)"), true); } BOOST_AUTO_TEST_CASE( test_is_valid_box ) { #ifdef BOOST_GEOMETRY_TEST_DEBUG std::cout << std::endl << std::endl; std::cout << "************************************" << std::endl; std::cout << " is_valid: BOX " << std::endl; std::cout << "************************************" << std::endl; #endif typedef box_type G; typedef default_validity_tester tester; typedef test_valid test; // boxes where the max corner and below and/or to the left of min corner test::apply(from_wkt("BOX(0 0,-1 0)"), false); test::apply(from_wkt("BOX(0 0,0 -1)"), false); test::apply(from_wkt("BOX(0 0,-1 -1)"), false); // boxes of zero area; they are not 2-dimensional, so invalid test::apply(from_wkt("BOX(0, 0, 0, 0)"), false); test::apply(from_wkt("BOX(0 0,1 0)"), false); test::apply(from_wkt("BOX(0 0,0 1)"), false); test::apply(from_wkt("BOX(0 0,1 1)"), true); } template void test_linestrings() { #ifdef BOOST_GEOMETRY_TEST_DEBUG std::cout << "SPIKES ALLOWED? " << std::boolalpha << AllowSpikes << std::noboolalpha << std::endl; #endif typedef validity_tester_linear tester; typedef test_valid test; // empty linestring test::apply(from_wkt("LINESTRING()"), false); // 1-point linestrings test::apply(from_wkt("LINESTRING(0 0)"), false); test::apply(from_wkt("LINESTRING(0 0,0 0)"), false); test::apply(from_wkt("LINESTRING(0 0,0 0,0 0)"), false); // 2-point linestrings test::apply(from_wkt("LINESTRING(0 0,1 2)"), true); test::apply(from_wkt("LINESTRING(0 0,1 2,1 2)"), true); test::apply(from_wkt("LINESTRING(0 0,0 0,1 2,1 2)"), true); test::apply(from_wkt("LINESTRING(0 0,0 0,0 0,1 2,1 2)"), true); // 3-point linestrings test::apply(from_wkt("LINESTRING(0 0,1 0,2 10)"), true); test::apply(from_wkt("LINESTRING(0 0,1 0,2 10,0 0)"), true); test::apply(from_wkt("LINESTRING(0 0,10 0,10 10,5 0)"), true); // linestrings with spikes test::apply(from_wkt("LINESTRING(0 0,1 2,0 0)"), AllowSpikes); test::apply(from_wkt("LINESTRING(0 0,1 2,1 2,0 0)"), AllowSpikes); test::apply(from_wkt("LINESTRING(0 0,0 0,1 2,1 2,0 0)"), AllowSpikes); test::apply(from_wkt("LINESTRING(0 0,0 0,0 0,1 2,1 2,0 0,0 0)"), AllowSpikes); test::apply(from_wkt("LINESTRING(0 0,10 0,5 0)"), AllowSpikes); test::apply(from_wkt("LINESTRING(0 0,10 0,10 10,5 0,0 0)"), AllowSpikes); test::apply(from_wkt("LINESTRING(0 0,10 0,10 10,5 0,4 0,6 0)"), AllowSpikes); test::apply(from_wkt("LINESTRING(0 0,1 0,1 1,5 5,4 4)"), AllowSpikes); test::apply(from_wkt("LINESTRING(0 0,1 0,1 1,5 5,4 4,6 6)"), AllowSpikes); test::apply(from_wkt("LINESTRING(0 0,1 0,1 1,5 5,4 4,4 0)"), AllowSpikes); test::apply(from_wkt("LINESTRING(0 0,0 0,1 0,1 0,1 0,0 0,0 0,2 0)"), AllowSpikes); test::apply(from_wkt("LINESTRING(0 0,1 0,0 0,2 0,0 0,3 0,0 0,4 0)"), AllowSpikes); test::apply(from_wkt("LINESTRING(0 0,1 0,0 0,2 0,0 0,3 0,0 0,4 0,0 0)"), AllowSpikes); // other examples test::apply(from_wkt("LINESTRING(0 0,10 0,10 10,5 0,4 0)"), true); test::apply(from_wkt("LINESTRING(0 0,10 0,10 10,5 0,4 0,3 0)"), true); test::apply(from_wkt("LINESTRING(0 0,10 0,10 10,5 0,4 0,-1 0)"), true); test::apply(from_wkt("LINESTRING(0 0,1 0,1 1,-1 1,-1 0,0 0)"), true); test::apply(from_wkt("LINESTRING(0 0,1 0,1 1,-1 1,-1 0,0.5 0)"), true); } BOOST_AUTO_TEST_CASE( test_is_valid_linestring ) { #ifdef BOOST_GEOMETRY_TEST_DEBUG std::cout << std::endl << std::endl; std::cout << "************************************" << std::endl; std::cout << " is_valid: LINESTRING " << std::endl; std::cout << "************************************" << std::endl; #endif bool const allow_spikes = true; bool const do_not_allow_spikes = !allow_spikes; test_linestrings(); test_linestrings(); } template void test_multilinestrings() { #ifdef BOOST_GEOMETRY_TEST_DEBUG std::cout << "SPIKES ALLOWED? " << std::boolalpha << AllowSpikes << std::noboolalpha << std::endl; #endif typedef validity_tester_linear tester; typedef test_valid test; // empty multilinestring test::apply(from_wkt("MULTILINESTRING()"), false); // multilinestring with empty linestring(s) test::apply(from_wkt("MULTILINESTRING(())"), false); test::apply(from_wkt("MULTILINESTRING((),(),())"), false); test::apply(from_wkt("MULTILINESTRING((),(0 1,1 0))"), false); // multilinestring with invalid linestrings test::apply(from_wkt("MULTILINESTRING((0 0),(0 1,1 0))"), false); test::apply(from_wkt("MULTILINESTRING((0 0,0 0),(0 1,1 0))"), false); test::apply(from_wkt("MULTILINESTRING((0 0),(1 0))"), false); test::apply(from_wkt("MULTILINESTRING((0 0,0 0),(1 0,1 0))"), false); test::apply(from_wkt("MULTILINESTRING((0 0),(0 0))"), false); test::apply(from_wkt("MULTILINESTRING((0 0,1 0,0 0),(5 0))"), false); // multilinstring that has linestrings with spikes test::apply(from_wkt("MULTILINESTRING((0 0,1 0,0 0),(5 0,1 0,4 1))"), AllowSpikes); test::apply(from_wkt("MULTILINESTRING((0 0,1 0,0 0),(1 0,2 0))"), AllowSpikes); // valid multilinestrings test::apply(from_wkt("MULTILINESTRING((0 0,1 0,2 0),(5 0,1 0,4 1))"), true); test::apply(from_wkt("MULTILINESTRING((0 0,1 0,2 0),(1 0,2 0))"), true); test::apply(from_wkt("MULTILINESTRING((0 0,1 1),(0 1,1 0))"), true); test::apply(from_wkt("MULTILINESTRING((0 0,1 1,2 2),(0 1,1 0,2 2))"), true); } BOOST_AUTO_TEST_CASE( test_is_valid_multilinestring ) { #ifdef BOOST_GEOMETRY_TEST_DEBUG std::cout << std::endl << std::endl; std::cout << "************************************" << std::endl; std::cout << " is_valid: MULTILINESTRING " << std::endl; std::cout << "************************************" << std::endl; #endif bool const allow_spikes = true; bool const do_not_allow_spikes = !allow_spikes; test_multilinestrings(); test_multilinestrings(); } template void test_open_rings() { #ifdef BOOST_GEOMETRY_TEST_DEBUG std::cout << std::endl << std::endl; std::cout << "************************************" << std::endl; std::cout << " is_valid: RING (open) " << std::endl; std::cout << "************************************" << std::endl; std::cout << "DUPLICATES ALLOWED? " << std::boolalpha << AllowDuplicates << std::noboolalpha << std::endl; #endif typedef bg::model::ring OG; // ccw, open ring typedef bg::model::ring CG; // ccw, closed ring typedef bg::model::ring CW_OG; // cw, open ring typedef bg::model::ring CW_CG; // cw, closed ring typedef validity_tester_areal tester; typedef test_valid test; // not enough points test::apply(from_wkt("POLYGON(())"), false); test::apply(from_wkt("POLYGON((0 0))"), false); test::apply(from_wkt("POLYGON((0 0,1 0))"), false); // duplicate points test::apply(from_wkt("POLYGON((0 0,0 0,0 0))"), false); test::apply(from_wkt("POLYGON((0 0,1 0,1 0))"), false); test::apply(from_wkt("POLYGON((0 0,1 0,0 0))"), false); test::apply(from_wkt("POLYGON((0 0,1 0,1 1,0 0))"), AllowDuplicates); test::apply(from_wkt("POLYGON((0 0,1 0,1 0,1 1))"), AllowDuplicates); test::apply(from_wkt("POLYGON((0 0,1 0,1 0,1 1,0 0))"), AllowDuplicates); // with spikes test::apply(from_wkt("POLYGON((0 0,2 0,2 2,0 2,1 2))"), false); test::apply(from_wkt("POLYGON((0 0,2 0,1 0,2 2))"), false); test::apply(from_wkt("POLYGON((0 0,1 0,2 0,1 0,4 0,4 4))"), false); test::apply(from_wkt("POLYGON((0 0,2 0,2 2,1 0))"), false); test::apply(from_wkt("POLYGON((0 0,2 0,1 0))"), false); test::apply(from_wkt("POLYGON((0 0,5 0,5 5,4 4,5 5,0 5))"), false); test::apply(from_wkt("POLYGON((0 0,5 0,5 5,4 4,3 3,5 5,0 5))"), false); // with spikes and duplicate points test::apply(from_wkt("POLYGON((0 0,0 0,2 0,2 0,1 0,1 0))"), false); // with self-crossings test::apply(from_wkt("POLYGON((0 0,5 0,5 5,3 -1,0 5))"), false); // with self-crossings and duplicate points test::apply(from_wkt("POLYGON((0 0,5 0,5 5,5 5,3 -1,0 5,0 5))"), false); // with self-intersections test::apply(from_wkt("POLYGON((0 0,5 0,5 5,3 5,3 0,2 0,2 5,0 5))"), false); test::apply(from_wkt("POLYGON((0 0,5 0,5 5,3 5,3 0,2 5,0 5))"), false); test::apply(from_wkt("POLYGON((0 0,5 0,5 1,1 1,1 2,2 2,3 1,4 2,5 2,5 5,0 5))"), false); // with self-intersections and duplicate points test::apply(from_wkt("POLYGON((0 0,5 0,5 5,3 5,3 5,3 0,3 0,2 0,2 0,2 5,2 5,0 5))"), false); // next two suggested by Adam Wulkiewicz test::apply(from_wkt("POLYGON((0 0,5 0,5 5,0 5,4 4,2 2,0 5))"), false); test::apply(from_wkt("POLYGON((0 0,5 0,5 5,1 4,4 4,4 1,0 5))"), false); // and a few more test::apply(from_wkt("POLYGON((0 0,5 0,5 5,4 4,1 4,1 1,4 1,4 4,0 5))"), false); test::apply(from_wkt("POLYGON((0 0,5 0,5 5,4 4,4 1,1 1,1 4,4 4,0 5))"), false); // valid rings test::apply(from_wkt("POLYGON((0 0,1 0,1 1))"), true); test::apply(from_wkt("POLYGON((1 0,1 1,0 0))"), true); test::apply(from_wkt("POLYGON((0 0,1 0,1 1,0 1))"), true); test::apply(from_wkt("POLYGON((1 0,1 1,0 1,0 0))"), true); } template void test_closed_rings() { #ifdef BOOST_GEOMETRY_TEST_DEBUG std::cout << std::endl << std::endl; std::cout << "************************************" << std::endl; std::cout << " is_valid: RING (closed) " << std::endl; std::cout << "************************************" << std::endl; std::cout << "DUPLICATES ALLOWED? " << std::boolalpha << AllowDuplicates << std::noboolalpha << std::endl; #endif typedef bg::model::ring CG; // ccw, closed ring typedef bg::model::ring CW_CG; // cw, closed ring typedef validity_tester_areal tester; typedef test_valid test; // not enough points test::apply(from_wkt("POLYGON(())"), false); test::apply(from_wkt("POLYGON((0 0))"), false); test::apply(from_wkt("POLYGON((0 0,0 0))"), false); test::apply(from_wkt("POLYGON((0 0,1 0))"), false); test::apply(from_wkt("POLYGON((0 0,1 0,1 0))"), false); test::apply(from_wkt("POLYGON((0 0,1 0,2 0))"), false); test::apply(from_wkt("POLYGON((0 0,1 0,1 0,2 0))"), false); test::apply(from_wkt("POLYGON((0 0,1 0,2 0,2 0))"), false); // boundary not closed test::apply(from_wkt("POLYGON((0 0,1 0,1 1,1 2))"), false); test::apply(from_wkt("POLYGON((0 0,1 0,1 0,1 1,1 1,1 2))"), false); } BOOST_AUTO_TEST_CASE( test_is_valid_ring ) { bool const allow_duplicates = true; bool const do_not_allow_duplicates = !allow_duplicates; test_open_rings(); test_open_rings(); test_closed_rings(); test_closed_rings(); } template void test_open_polygons() { #ifdef BOOST_GEOMETRY_TEST_DEBUG std::cout << std::endl << std::endl; std::cout << "************************************" << std::endl; std::cout << " is_valid: POLYGON (open) " << std::endl; std::cout << "************************************" << std::endl; std::cout << "DUPLICATES ALLOWED? " << std::boolalpha << AllowDuplicates << std::noboolalpha << std::endl; #endif typedef bg::model::polygon OG; // ccw, open typedef bg::model::polygon CG; // ccw, closed typedef bg::model::polygon CW_OG; // cw, open typedef bg::model::polygon CW_CG; // cw, closed typedef validity_tester_areal tester; typedef test_valid test; // not enough points in exterior ring test::apply(from_wkt("POLYGON(())"), false); test::apply(from_wkt("POLYGON((0 0))"), false); test::apply(from_wkt("POLYGON((0 0,1 0))"), false); // not enough points in interior ring test::apply(from_wkt("POLYGON((0 0,10 0,10 10,0 10),())"), false); test::apply(from_wkt("POLYGON((0 0,10 0,10 10,0 10),(1 1))"), false); test::apply(from_wkt("POLYGON((0 0,10 0,10 10,0 10),(1 1,2 2))"), false); // duplicate points in exterior ring test::apply(from_wkt("POLYGON((0 0,0 0,0 0))"), false); test::apply(from_wkt("POLYGON((0 0,1 0,1 0))"), false); test::apply(from_wkt("POLYGON((0 0,1 0,0 0))"), false); test::apply(from_wkt("POLYGON((0 0,1 0,1 1,0 0))"), AllowDuplicates); test::apply(from_wkt("POLYGON((0 0,1 0,1 0,1 1))"), AllowDuplicates); test::apply(from_wkt("POLYGON((0 0,1 0,1 0,1 1,0 0))"), AllowDuplicates); // duplicate points in interior ring test::apply(from_wkt("POLYGON((0 0,10 0,10 10,0 10),(1 1,1 1,1 1))"), false); test::apply(from_wkt("POLYGON((0 0,10 0,10 10,0 10),(1 1,2 1,2 1))"), false); test::apply(from_wkt("POLYGON((0 0,10 0,10 10,0 10),(1 1,2 1,1 1))"), false); test::apply(from_wkt("POLYGON((0 0,10 0,10 10,0 10),(1 1,2 2,2 1,1 1))"), AllowDuplicates); test::apply(from_wkt("POLYGON((0 0,10 0,10 10,0 10),(1 1,2 2,2 2,2 1))"), AllowDuplicates); test::apply(from_wkt("POLYGON((0 0,10 0,10 10,0 10),(1 1,2 2,2 1,2 1,1 1))"), AllowDuplicates); // with spikes in exterior ring test::apply(from_wkt("POLYGON((0 0,2 0,2 2,0 2,1 2))"), false); test::apply(from_wkt("POLYGON((0 0,2 0,1 0,2 2))"), false); test::apply(from_wkt("POLYGON((0 0,1 0,2 0,1 0,4 0,4 4))"), false); test::apply(from_wkt("POLYGON((0 0,2 0,2 2,1 0))"), false); test::apply(from_wkt("POLYGON((0 0,2 0,1 0))"), false); test::apply(from_wkt("POLYGON((0 0,5 0,5 5,4 4,5 5,0 5))"), false); test::apply(from_wkt("POLYGON((0 0,5 0,5 5,4 4,3 3,5 5,0 5))"), false); // with spikes in interior ring test::apply(from_wkt("POLYGON((0 0,10 0,10 10,0 10),(1 1,3 1,3 3,1 3,2 3))"), false); test::apply(from_wkt("POLYGON((0 0,10 0,10 10,0 10),(1 1,3 1,2 1,3 3))"), false); test::apply(from_wkt("POLYGON((0 0,10 0,10 10,0 10),(1 1,2 1,3 1,2 1,4 1,4 4))"), false); test::apply(from_wkt("POLYGON((0 0,10 0,10 10,0 10),(1 1,3 1,3 3,2 1))"), false); test::apply(from_wkt("POLYGON((0 0,10 0,10 10,0 10),(1 1,3 1,2 1))"), false); // with self-crossings in exterior ring test::apply(from_wkt("POLYGON((0 0,5 0,5 5,3 -1,0 5))"), false); // example from Norvald Ryeng test::apply(from_wkt("POLYGON((100 1300,140 1300,140 170,100 1700))"), false); // and with point order reversed test::apply(from_wkt("POLYGON((100 1300,100 1700,140 170,140 1300))"), false); // with self-crossings in interior ring test::apply(from_wkt("POLYGON((0 0,10 0,10 10,0 10),(3 3,3 7,4 6,2 6))"), false); // with self-crossings between rings test::apply(from_wkt("POLYGON((0 0,5 0,5 5,0 5),(1 1,2 1,1 -1))"), false); // with self-intersections in exterior ring test::apply(from_wkt("POLYGON((0 0,5 0,5 5,3 5,3 0,2 0,2 5,0 5))"), false); test::apply(from_wkt("POLYGON((0 0,5 0,5 5,3 5,3 0,2 5,0 5))"), false); test::apply(from_wkt("POLYGON((0 0,5 0,5 1,1 1,1 2,2 2,3 1,4 2,5 2,5 5,0 5))"), false); // next two suggested by Adam Wulkiewicz test::apply(from_wkt("POLYGON((0 0,5 0,5 5,0 5,4 4,2 2,0 5))"), false); test::apply(from_wkt("POLYGON((0 0,5 0,5 5,1 4,4 4,4 1,0 5))"), false); test::apply(from_wkt("POLYGON((0 0,5 0,5 5,4 4,1 4,1 1,4 1,4 4,0 5))"), false); test::apply(from_wkt("POLYGON((0 0,5 0,5 5,4 4,4 1,1 1,1 4,4 4,0 5))"), false); // with self-intersections in interior ring test::apply(from_wkt("POLYGON((-10 -10,10 -10,10 10,-10 10),(0 0,5 0,5 5,3 5,3 0,2 0,2 5,0 5))"), false); test::apply(from_wkt("POLYGON((-10 -10,10 -10,10 10,-10 10),(0 0,5 0,5 5,3 5,3 0,2 5,0 5))"), false); test::apply(from_wkt("POLYGON((-10 -10,10 -10,10 10,-10 10),(0 0,5 0,5 1,1 1,1 2,2 2,3 1,4 2,5 2,5 5,0 5))"), false); // with self-intersections between rings // hole has common segment with exterior ring test::apply(from_wkt("POLYGON((0 0,10 0,10 10,0 10),(1 1,1 10,2 10,2 1))"), false); test::apply(from_wkt("POLYGON((0 0,0 0,10 0,10 10,0 10,0 10),(1 1,1 10,1 10,2 10,2 10,2 1))"), false); // hole touches exterior ring at one point test::apply(from_wkt("POLYGON((0 0,10 0,10 10,0 10),(1 1,1 10,2 1))"), true); // "hole" is outside the exterior ring, but touches it test::apply(from_wkt("POLYGON((0 0,10 0,10 10,0 10),(5 10,4 11,6 11))"), false); // hole touches exterior ring at vertex test::apply(from_wkt("POLYGON((0 0,10 0,10 10,0 10),(0 0,1 4,4 1))"), true); // "hole" is completely outside the exterior ring test::apply(from_wkt("POLYGON((0 0,10 0,10 10,0 10),(20 20,20 21,21 21,21 20))"), false); // example from Norvald Ryeng test::apply(from_wkt("POLYGON((58 31,56.57 30,62 33),(35 9,28 14,31 16),(23 11,29 5,26 4))"), false); // and with points reversed test::apply(from_wkt("POLYGON((58 31,62 33,56.57 30),(35 9,31 16,28 14),(23 11,26 4,29 5))"), false); // "hole" is completely inside another "hole" test::apply(from_wkt("POLYGON((0 0,10 0,10 10,0 10),(1 1,1 9,9 9,9 1),(2 2,2 8,8 8,8 2))"), false); test::apply(from_wkt("POLYGON((0 0,10 0,10 10,0 10),(1 1,1 9,9 9,9 1),(2 2,8 2,8 8,2 8))"), false); // "hole" is inside another "hole" (touching) test::apply(from_wkt("POLYGON((0 0,10 0,10 10,0 10),(1 1,1 9,9 9,9 1),(2 2,2 8,8 8,9 6,8 2))"), false); test::apply(from_wkt("POLYGON((0 0,10 0,10 10,0 10),(1 1,1 9,9 9,9 1),(2 2,8 2,9 6,8 8,2 8))"), false); test::apply(from_wkt("POLYGON((0 0,10 0,10 10,0 10),(1 1,9 1,9 9,1 9),(2 2,2 8,8 8,9 6,8 2))"), false); test::apply(from_wkt("POLYGON((0 0,10 0,10 10,0 10),(1 1,9 1,9 9,1 9),(2 2,8 2,9 6,8 8,2 8))"), false); // hole touches exterior ring at two points test::apply(from_wkt("POLYGON((0 0,10 0,10 10,0 10),(5 0,0 5,5 5))"), false); // cases with more holes // two holes, touching the exterior at the same point test::apply(from_wkt("POLYGON((0 0,10 0,10 10,0 10),(0 0,1 9,2 9),(0 0,9 2,9 1))"), true); test::apply(from_wkt("POLYGON((0 0,0 0,10 0,10 10,0 10,0 0),(0 0,0 0,1 9,2 9),(0 0,0 0,9 2,9 1))"), AllowDuplicates); test::apply(from_wkt("POLYGON((0 10,0 0,0 0,0 0,10 0,10 10),(2 9,0 0,0 0,1 9),(9 1,0 0,0 0,9 2))"), AllowDuplicates); // two holes, one inside the other test::apply(from_wkt("POLYGON((0 0,10 0,10 10,0 10),(0 0,1 9,9 1),(0 0,4 5,5 4))"), false); // 1st hole touches has common segment with 2nd hole test::apply(from_wkt("POLYGON((0 0,10 0,10 10,0 10),(1 1,1 5,5 5,5 1),(5 4,5 8,8 8,8 4))"), false); // 1st hole touches 2nd hole at two points test::apply(from_wkt("POLYGON((0 0,10 0,10 10,0 10),(1 1,1 9,9 9,9 8,2 8,2 1),(2 5,5 8,5 5))"), false); // four holes, each two touching at different points test::apply(from_wkt("POLYGON((0 0,10 0,10 10,0 10),(0 10,2 1,1 1),(0 10,4 1,3 1),(10 10,9 1,8 1),(10 10,7 1,6 1))"), true); // five holes, with two pairs touching each at some point, and // fifth hole creating a disconnected component for the interior test::apply(from_wkt("POLYGON((0 0,10 0,10 10,0 10),(0 10,2 1,1 1),(0 10,4 1,3 1),(10 10,9 1,8 1),(10 10,7 1,6 1),(4 1,4 4,6 4,6 1))"), false); // five holes, with two pairs touching each at some point, and // fifth hole creating three disconnected components for the interior test::apply(from_wkt("POLYGON((0 0,10 0,10 10,0 10),(0 10,2 1,1 1),(0 10,4 1,3 1),(10 10,9 1,8 1),(10 10,7 1,6 1),(4 1,4 4,6 4,6 1,5 0))"), false); } BOOST_AUTO_TEST_CASE( test_is_valid_polygon ) { bool const allow_duplicates = true; bool const do_not_allow_duplicates = !allow_duplicates; test_open_polygons(); test_open_polygons(); } template void test_open_multipolygons() { #ifdef BOOST_GEOMETRY_TEST_DEBUG std::cout << std::endl << std::endl; std::cout << "************************************" << std::endl; std::cout << " is_valid: MULTIPOLYGON (open) " << std::endl; std::cout << "************************************" << std::endl; std::cout << "DUPLICATES ALLOWED? " << std::boolalpha << AllowDuplicates << std::noboolalpha << std::endl; #endif // cw, ccw, open and closed polygons typedef bg::model::polygon ccw_open_polygon_type; typedef bg::model::polygon ccw_closed_polygon_type; typedef bg::model::polygon cw_open_polygon_type; typedef bg::model::polygon cw_closed_polygon_type; typedef bg::model::multi_polygon OG; typedef bg::model::multi_polygon CG; typedef bg::model::multi_polygon CW_OG; typedef bg::model::multi_polygon CW_CG; typedef validity_tester_areal tester; typedef test_valid test; test::apply(from_wkt("MULTIPOLYGON((()))"), false); test::apply(from_wkt("MULTIPOLYGON(((0 0)),(()))"), false); test::apply(from_wkt("MULTIPOLYGON(((0 0,1 0)))"), false); test::apply(from_wkt("MULTIPOLYGON(((0 0,1 0,1 1,0 1)),((2 2,3 2,3 3,2 3)))"), true); test::apply(from_wkt("MULTIPOLYGON(((0 0,1 0,1 0,1 1,0 1)),((2 2,3 2,3 3,3 3,2 3)))"), AllowDuplicates); } BOOST_AUTO_TEST_CASE( test_is_valid_multipolygon ) { bool const allow_duplicates = true; bool const do_not_allow_duplicates = !allow_duplicates; test_open_multipolygons(); test_open_multipolygons(); } BOOST_AUTO_TEST_CASE( test_is_valid_variant ) { #ifdef BOOST_GEOMETRY_TEST_DEBUG std::cout << std::endl << std::endl; std::cout << "************************************" << std::endl; std::cout << " is_valid: variant support" << std::endl; std::cout << "************************************" << std::endl; #endif typedef bg::model::polygon polygon_type; // cw, closed typedef boost::variant < linestring_type, multi_linestring_type, polygon_type > variant_geometry; typedef test_valid_variant test; variant_geometry vg; linestring_type valid_linestring = from_wkt("LINESTRING(0 0,1 0)"); multi_linestring_type invalid_multi_linestring = from_wkt("MULTILINESTRING((0 0,1 0),(0 0))"); polygon_type valid_polygon = from_wkt("POLYGON((0 0,1 1,1 0,0 0))"); polygon_type invalid_polygon = from_wkt("POLYGON((0 0,1 1,1 0))"); vg = valid_linestring; test::apply(vg, true); vg = invalid_multi_linestring; test::apply(vg, false); vg = valid_polygon; test::apply(vg, true); vg = invalid_polygon; test::apply(vg, false); }