boost_mirror/geometry
1
0
Fork 0
mirror of https://github.com/boostorg/geometry.git synced 2025-05-11 13:34:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

[test] dissolve algorithm cannot use bg::correct, because orientation is

Browse Source 
unknown and can be wrong. Orientation should not be reversed. Therefore
correct_closure is split of from correct, and can (should) be used to
close the geometries correctly. Only then some cases of dissolve can be
fixed. bg::dissolve can itself not close the rings by design of the library
(it would require drastic changes)
This commit is contained in:
Barend Gehrels 2017-10-19 16:38:49 +02:00
parent 0f098948b2
commit aa6778e83c
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
extensions/test/algorithms/dissolve.cpp
View File

@ -16,6 +16,7 @@
#include <boost/geometry/extensions/multi/algorithms/dissolve.hpp>
// To check results
#include <boost/geometry/algorithms/correct_closure.hpp>
#include <boost/geometry/algorithms/length.hpp>
#include <boost/geometry/algorithms/area.hpp>
#include <boost/geometry/algorithms/is_valid.hpp>
@ -451,6 +452,10 @@ void test_one(std::string const& caseid, std::string const& wkt,
Geometry geometry;
bg::read_wkt(wkt, geometry);
// If defined as closed, it should be closed. The algorithm itself
// cannot close it without making a copy.
bg::correct_closure(geometry);
test_dissolve<GeometryOut>(caseid, geometry,
expected_area,
expected_clip_count, expected_hole_count, expected_point_count,
@ -526,10 +531,9 @@ void test_all()
TEST_DISSOLVE(dissolve_mail_2017_09_24_a, 0.5, 2, 0, 8);
// These do not have closed input, and output is not closed either. TODO.
TEST_DISSOLVE_IGNORE(dissolve_mail_2017_09_24_b, 16.0, 1, 0, 5);
TEST_DISSOLVE_IGNORE(dissolve_mail_2017_09_24_c, 0.4999, 1, 0, 4);
TEST_DISSOLVE_IGNORE(dissolve_mail_2017_09_24_d, 0.5, 1, 0, 4);
TEST_DISSOLVE(dissolve_mail_2017_09_24_b, 16.0, 1, 0, 6);
TEST_DISSOLVE(dissolve_mail_2017_09_24_c, 0.5, 2, 0, 8);
TEST_DISSOLVE_IGNORE(dissolve_mail_2017_09_24_d, 0.5, 1, 0, 5);
TEST_DISSOLVE(dissolve_mail_2017_09_24_e, 0.001801138128, 5, 0, 69);
TEST_DISSOLVE(dissolve_mail_2017_09_24_f, 0.000361308800, 5, 0, 69);