boost_mirror/coroutine2
1
0
Fork 0
mirror of https://github.com/boostorg/coroutine2.git synced 2025-05-11 05:24:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

[pull_coroutine] iterators model C++20 InputIterator

Browse Source 
The C++20 `InputIterator` concept requires post-increment indirectly via the [`WeaklyIncrementable`](http://eel.is/c++draft/iterator.concept.winc) concept, but doesn't constrain the return type unlike the "old [input iterator requirements](http://eel.is/c++draft/input.iterators). Consequently the iterators of coroutine generators - such as `pull_coroutine` - can model `InputIterator`.

Drive-by: Remove explicit implementations of copy construction/assignment that do what the default implementations would; don't pessimize by avoiding self-swap of pointers.
This commit is contained in:
Casey Carter 2018-12-05 09:26:52 -08:00 committed by GitHub
parent b029799da7
commit f885fb2c91
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
include/boost/coroutine2/detail/pull_coroutine.hpp
View File

@ -55,7 +55,6 @@ public:
pull_coroutine( pull_coroutine &&) noexcept; pull_coroutine( pull_coroutine &&) noexcept;
pull_coroutine & operator=( pull_coroutine && other) noexcept { pull_coroutine & operator=( pull_coroutine && other) noexcept {
if ( this == & other) return * this;
std::swap( cb_, other.cb_); std::swap( cb_, other.cb_);
return * this; return * this;
} }
@ -104,16 +103,6 @@ public:
fetch_(); fetch_();
} }
iterator( iterator const& other) noexcept :
c_{ other.c_ } {
}
iterator & operator=( iterator const& other) noexcept {
if ( this == & other) return * this;
c_ = other.c_;
return * this;
}
bool operator==( iterator const& other) const noexcept { bool operator==( iterator const& other) const noexcept {
return other.c_ == c_; return other.c_ == c_;
} }
@ -127,7 +116,9 @@ public:
return * this; return * this;
} }
iterator operator++( int) = delete; void operator++( int) {
increment_();
}
reference_t operator*() const noexcept { reference_t operator*() const noexcept {
return c_->cb_->get(); return c_->cb_->get();
@ -172,7 +163,6 @@ public:
pull_coroutine( pull_coroutine &&) noexcept; pull_coroutine( pull_coroutine &&) noexcept;
pull_coroutine & operator=( pull_coroutine && other) noexcept { pull_coroutine & operator=( pull_coroutine && other) noexcept {
if ( this == & other) return * this;
std::swap( cb_, other.cb_); std::swap( cb_, other.cb_);
return * this; return * this;
} }
@ -221,16 +211,6 @@ public:
fetch_(); fetch_();
} }
iterator( iterator const& other) noexcept :
c_{ other.c_ } {
}
iterator & operator=( iterator const& other) noexcept {
if ( this == & other) return * this;
c_ = other.c_;
return * this;
}
bool operator==( iterator const& other) const noexcept { bool operator==( iterator const& other) const noexcept {
return other.c_ == c_; return other.c_ == c_;
} }
@ -244,7 +224,9 @@ public:
return * this; return * this;
} }
iterator operator++( int) = delete; void operator++( int) {
increment_();
}
reference_t operator*() const noexcept { reference_t operator*() const noexcept {
return c_->cb_->get(); return c_->cb_->get();
@ -287,7 +269,6 @@ public:
pull_coroutine( pull_coroutine &&) noexcept; pull_coroutine( pull_coroutine &&) noexcept;
pull_coroutine & operator=( pull_coroutine && other) noexcept { pull_coroutine & operator=( pull_coroutine && other) noexcept {
if ( this == & other) return * this;
std::swap( cb_, other.cb_); std::swap( cb_, other.cb_);
return * this; return * this;
} }